Skip to content

mockgen deprecated: use uber-go/mock instead#443

Open
sebrandon1 wants to merge 1 commit intoopenshift:masterfrom
sebrandon1:mockgen_deprecation
Open

mockgen deprecated: use uber-go/mock instead#443
sebrandon1 wants to merge 1 commit intoopenshift:masterfrom
sebrandon1:mockgen_deprecation

Conversation

@sebrandon1
Copy link
Member

@sebrandon1 sebrandon1 commented Nov 13, 2025

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

The changes to the generated/ files are because of the new library.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

@openshift-ci openshift-ci bot requested review from anispate and clcollins November 13, 2025 20:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 38.70968% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.57%. Comparing base (27d9cae) to head (4c02cf4).

Files with missing lines Patch % Lines
pkg/util/test/generated/mocks/client/cr-client.go 42.55% 22 Missing and 5 partials ⚠️
.../util/test/generated/mocks/client/status-writer.go 26.66% 10 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files          30       30           
  Lines        2618     2618           
=======================================
  Hits         1455     1455           
  Misses       1074     1074           
  Partials       89       89
Files with missing lines Coverage Δ
...til/test/generated/mocks/controllers/interfaces.go 75.52% <ø> (ø)
pkg/util/test/generated/mocks/reconcile/common.go 100.00% <ø> (ø)
.../util/test/generated/mocks/client/status-writer.go 38.09% <26.66%> (ø)
pkg/util/test/generated/mocks/client/cr-client.go 45.71% <42.55%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generate 4c02cf4 link true /test generate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sebrandon1 sebrandon1 mentioned this pull request Nov 14, 2025
Open
@clcollins
Copy link
Member

clcollins commented Nov 21, 2025

/lgtm

@clcollins
Copy link
Member

clcollins commented Nov 21, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 22, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

openshift-bot commented Feb 21, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anispate anispate Awaiting requested review from anispate

@clcollins clcollins Awaiting requested review from clcollins

Assignees

@clcollins clcollins

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebrandon1 @codecov-commenter @clcollins @openshift-merge-robot @openshift-bot